Skip to content

fix(debug-loop): add Plan Mode rejection/revision loop#191

Merged
maystudios merged 1 commit intomainfrom
worktree-agent-aa16ccd8
Mar 25, 2026
Merged

fix(debug-loop): add Plan Mode rejection/revision loop#191
maystudios merged 1 commit intomainfrom
worktree-agent-aa16ccd8

Conversation

@maystudios
Copy link
Copy Markdown
Owner

Summary

  • Add explicit rejection/revision loop to /maxsim:debug-loop Plan Mode setup (§8 audit gap)
  • Users can now revise parameters and re-confirm before investigation starts
  • Cancel path cleans up pre-created GitHub Issue via gh issue close

Test plan

  • Verify markdown syntax is correct
  • Confirm step numbering flows naturally into Phase 2

🤖 Generated with Claude Code

Add explicit handling for user rejection and cancellation during the
Plan Mode setup phase. Users can now revise parameters, re-attempt
reproduction, and update the GitHub Issue before confirming. Cancel
path cleans up the pre-created GitHub Issue.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 25, 2026 21:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an explicit Plan Mode “reject/revise/confirm” loop to the /maxsim:debug-loop command so users can request changes (and re-run reproduction if needed) before the autonomous investigation begins, with a cancel path that closes the pre-created tracking issue.

Changes:

  • Insert a user confirmation loop after presenting the investigation plan (approve / request changes / cancel).
  • On “request changes”, revise parameters, optionally re-run reproduction, update the tracking issue, and re-confirm.
  • On “cancel”, close the tracking issue and exit Plan Mode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +39 to +40
- **If user requests changes:** revise the relevant parameters (scope, reproduction command, investigation approach). If the reproduction command changed, re-attempt reproduction (step 3). Update the GitHub Issue body with the revised plan. Return to step 5 (stay in Plan Mode).
- **If user cancels:** close the GitHub Issue created in step 4 (`gh issue close {ISSUE_NUM} --comment "Debug session cancelled by user before investigation began"`), Exit Plan Mode via ExitPlanMode, and stop.
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 6’s cancel path references {ISSUE_NUM}, but this template otherwise uses $... variables (e.g., $ARGUMENTS) and doesn’t define/capture an issue number in step 4. This makes the cancellation instruction ambiguous/unenforceable. Consider explicitly capturing the created issue number/URL in step 4 and then referencing it consistently here (e.g., $ISSUE_NUM, consistent with templates/workflows/debug.md).

Copilot uses AI. Check for mistakes.
@maystudios maystudios merged commit 3c7d266 into main Mar 25, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants